Match OSP split by backkem · Pull Request #57 · WICG/local-peer-to-peer

backkem · 2025-05-23T07:03:21Z

I asked Jules to rewrite the spec to match the OSP split.

WIP since I still need to review in detail.

…n Screen Protocol. The Open Screen Protocol is now two separate protocols: - Open Screen Network Protocol (https://www.w3.org/TR/openscreen-network/) - Open Screen Application Protocol (https://www.w3.org/TR/openscreen-application/) I've gone through the repository and updated all references from the general "Open Screen Protocol" to the more specific "Open Screen Network Protocol." I also updated all relevant links to point to the new specification URL. The following files have been updated: - EXPLAINER.md - index.bs - security-privacy-questionnaire.md

anssiko · 2025-05-23T09:24:01Z

Let's put more agents to work. I just asked Copilot to review this PR from Jules.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

backkem · 2025-05-23T09:27:22Z

Let's put more agents to work. I just asked Copilot to review this PR from Jules.

I wonder if it'll be able to see the CI error. If so, it may have a chance at fixing it.

anssiko · 2025-05-23T09:59:30Z

Let's see how far we can go. 😄

I'll ask for Copilot re-review, but let's first give it some more context by asking it for a solution.

Here's the ask:

Please find a solution for failing job 42764191221. Use the logs, job definition, and any referenced files where the failure occurred. Keep your response focused on the solution and include code suggestions when appropriate.

And below is the Copilot's suggested solution to its future self:

The failing job encountered errors related to the Bikeshed build process due to obsolete and ambiguous references in the index.bs file. Here's how to resolve the issue:

Identified Problems

Obsolete Biblio Reference:

[openscreenprotocol] is obsolete and replaced by [openscreen-network].

The correct reference URL for [openscreen-network] is already defined in the file.

Ambiguous Definition for "allowed to use":

The Bikeshed tool detected multiple possible references for "allowed to use."

Solution

Update the Obsolete Reference

Replace all occurrences of [openscreenprotocol] with [openscreen-network]. If this reference is intentionally obsolete, use [openscreenprotocol obsolete].

Resolve the Ambiguous Definition

Add a <pre class="link-defaults"> block to specify the intended reference for "allowed to use." For example:
<pre class="link-defaults">
spec:html; type:dfn; text:allowed to use
</pre>
This ensures that Bikeshed selects the correct definition during the build.

Updated index.bs Changes
16| !openscreenprotocol: https://www.w3.org/TR/openscreen-network/ Open Screen Network Protocol
Replace with:
16| !openscreen-network: https://www.w3.org/TR/openscreen-network/ Open Screen Network
And ensure all instances of [openscreenprotocol] are replaced with [openscreen-network].

Add the following block near the top of the file (after metadata or where appropriate):
<pre class="link-defaults">
spec:html; type:dfn; text:allowed to use
</pre>
Steps to Verify

Apply the changes to the index.bs file.

Rerun the Bikeshed build command:
bikeshed --die-on=warning spec index.bs index.bs.built.html
Push the updated file and trigger the workflow again.

This should resolve the issues and allow the workflow to complete successfully. Let me know if you need further assistance!

Copilot

Pull Request Overview

This PR updates documentation to match the split of the Open Screen Protocol into the Open Screen Network Protocol.

Renames occurrences of “Open Screen Protocol” to “Open Screen Network Protocol”
Updates corresponding links in the security/ privacy questionnaire and the explainer

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
security-privacy-questionnaire.md	Updated protocol name and link in question 7 and 14
EXPLAINER.md	Updated protocol name and link in three sections

Files not reviewed (1)

index.bs: Language not supported

anssiko · 2025-05-23T10:13:16Z

Copilot did not figure out the build is failing, and apparently Bikeshed language is not supported (see Files not reviewed (1)).

I gave it feedback via 👎 that its suggestion did not solve the problem.

Humans are still needed for spec work. 😄

anssiko · 2025-05-23T10:15:48Z

Perhaps we need to convert the PR to Ready for review to allow Copilot really get to work? Let's try.

Copilot

Pull Request Overview

This pull request updates protocol references from "Open Screen Protocol" to "Open Screen Network Protocol" to better reflect the current specifications.

Updated protocol name and associated link in the security and privacy questionnaire.
Revised protocol references in the explanation document for clarity and consistency.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
security-privacy-questionnaire.md	Updated protocol name and link in Q7 and Q14 to match the OSP split requirements.
EXPLAINER.md	Revised protocol name and link in multiple sections and adjusted associated descriptive text.

Files not reviewed (1)

index.bs: Language not supported

Comments suppressed due to low confidence (1)

security-privacy-questionnaire.md:42

The sentence contains a grammatical issue: 'specification' is singular, so 'are to be followed' should be changed to 'is to be followed'.

-    - A: The [specification](https://www.w3.org/TR/openscreen-network/#private-browsing-mode) of the Open Screen Network Protocol are to be followed in this area.

Copilot · 2025-05-23T10:16:15Z

EXPLAINER.md

 ## Solution Approach

-The Local Peer-to-Peer API uses the to mutual authentication provided by the Open Screen Protocol to establish mutual TLS certificates between peers. These certificates serve as a trust anchor for secure [local communication](https://wicg.github.io/local-peer-to-peer/#local-communication). The Local Peer-to-Peer specification defines two uses of this new trust anchor:
+The Local Peer-to-Peer API uses the to mutual authentication provided by the Open Screen Network Protocol to establish mutual TLS certificates between peers. These certificates serve as a trust anchor for secure [local communication](https://wicg.github.io/local-peer-to-peer/#local-communication). The Local Peer-to-Peer specification defines two uses of this new trust anchor:


There appears to be an extraneous word 'to' before 'mutual authentication'; consider removing it for clarity.

anssiko · 2025-05-23T10:39:18Z

OK, let's try one more thing. This is how you fix the build, Copilot:

sed 's/!openscreenprotocol/!openscreen-network/g' index.bs

Copilot

Pull Request Overview

This PR updates references to the new Open Screen Network Protocol across the specification documents.

Updated protocol names and links in security-privacy-questionnaire.md.
Updated protocol names, associated links, and reference texts in EXPLAINER.md.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
security-privacy-questionnaire.md	Updated protocol name and link for a question and private browsing mode.
EXPLAINER.md	Updated protocol name, links, and reference text regarding API authentication.

Files not reviewed (1)

index.bs: Language not supported

Copilot · 2025-05-23T10:39:44Z

EXPLAINER.md

 ## Solution Approach

-The Local Peer-to-Peer API uses the to mutual authentication provided by the Open Screen Protocol to establish mutual TLS certificates between peers. These certificates serve as a trust anchor for secure [local communication](https://wicg.github.io/local-peer-to-peer/#local-communication). The Local Peer-to-Peer specification defines two uses of this new trust anchor:
+The Local Peer-to-Peer API uses the to mutual authentication provided by the Open Screen Network Protocol to establish mutual TLS certificates between peers. These certificates serve as a trust anchor for secure [local communication](https://wicg.github.io/local-peer-to-peer/#local-communication). The Local Peer-to-Peer specification defines two uses of this new trust anchor:


The phrase 'uses the to mutual authentication' appears to be a typo. Consider revising it to 'uses the mutual authentication' for clarity.

anssiko · 2025-05-23T10:43:01Z

@backkem, it indeed looks like we still need a human reviewer to fix the build 😄 I'll stop bugging Copilot for now.

This commit removes the <pre class="link-defaults"> block for "allowed to use" from index.bs, as it was deemed unnecessary. The biblio updates for "openscreen-network" remain in place.

This commit re-adds the <pre class="link-defaults"> block for "allowed to use" to index.bs, ensuring it is separated from the metadata block by a double newline as requested for CI purposes. The biblio updates for "openscreen-network" remain in place.

backkem · 2025-05-23T17:24:37Z

Just sharing learnings if anyone is interested:
Jules was able to follow copilot chat's suggestion 😂. It's just sad that Jules is very slow ATM. Replit agent would have fixed this in seconds, but Jules being able to manage it's own "tasks" is quite handy. I didn't try Codex yet.
I did try "vibe coding" a Go Spake2 implementation in backkem/spake2-go using Replit. It's tantalizingly close but no cigar. I may try to find the time to fix it manually.

index.bs

anssiko · 2025-05-27T12:56:50Z

@backkem I reviewer Jules' changes and gave some hints. 🤖

Co-authored-by: Anssi Kostiainen <anssi.kostiainen@intel.com>

anssiko · 2025-05-27T13:26:48Z

Let's merge this. Copilot found some grammar nits, but better handle those separately. The learning here is Jules needs to read some more Bikeshed docs.

anssiko requested a review from Copilot May 23, 2025 09:23

Copilot AI reviewed May 23, 2025

View reviewed changes

anssiko requested a review from Copilot May 23, 2025 09:59

Copilot AI reviewed May 23, 2025

View reviewed changes

anssiko marked this pull request as ready for review May 23, 2025 10:15

anssiko requested a review from Copilot May 23, 2025 10:15

Copilot AI reviewed May 23, 2025

View reviewed changes

anssiko requested a review from Copilot May 23, 2025 10:39

Copilot AI reviewed May 23, 2025

View reviewed changes

google-labs-jules bot added 2 commits May 23, 2025 17:11

Docs: Remove link-defaults block from index.bs

1d1631f

This commit removes the <pre class="link-defaults"> block for "allowed to use" from index.bs, as it was deemed unnecessary. The biblio updates for "openscreen-network" remain in place.

anssiko requested changes May 27, 2025

View reviewed changes

index.bs Outdated Show resolved Hide resolved

avoid unneeded reference

6557d60

Co-authored-by: Anssi Kostiainen <anssi.kostiainen@intel.com>

anssiko approved these changes May 27, 2025

View reviewed changes

anssiko merged commit 9297123 into WICG:main May 27, 2025
2 checks passed

Comments

Conversation

backkem commented May 23, 2025 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anssiko commented May 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

backkem commented May 23, 2025

Uh oh!

anssiko commented May 23, 2025

Identified Problems

Solution

Updated index.bs Changes

Steps to Verify

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

anssiko commented May 23, 2025

Uh oh!

anssiko commented May 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

anssiko commented May 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

anssiko commented May 23, 2025

Uh oh!

backkem commented May 23, 2025

Uh oh!

Uh oh!

anssiko commented May 27, 2025

Uh oh!

anssiko commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

backkem commented May 23, 2025 •

edited by pr-preview bot

Loading